-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime Implementation #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the shim methods though...
ec2
requested review from
ansermino,
austinabell and
dutterbutter
as code owners
March 30, 2020 22:50
austinabell
suggested changes
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write some tests for this logic, seems it isn't doing what you think it is
dutterbutter
approved these changes
Apr 6, 2020
austinabell
suggested changes
Apr 7, 2020
austinabell
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
#67
Other information and links
There are still a few things that need to be done. Namely, we still need to implement gas calculations. Until we have that, there we obviously cannot calculate the gas cost of calls. Also, we won't be able to verify some of the things that need to be verified. I have marked these as TODO.
Also, I have left the Runtime package in because that is where the Runtime trait lives. It is debatable as to whether we need a Runtime trait and I am heavily leaning on removing it altogether. The initial reason we had the Runtime trait is to create different Runtime for testing, for example. However, we can mock those, which might actually make things a lot more easier. I figured that I'll leave the trait in here meanwhile, and possibly remove it when we start doing the Actors testing... But as an FYI, the VM is currently using the DefaultRuntime struct instead of referencing the trait. It is a LOT more easier to do it like this...
The logic for the Lotus' send functions are in runtime.go and vm.go here https://github.com/filecoin-project/lotus/tree/testnet/3/chain/vm
@austinabell @dutterbutter