feat: add --diff flag to archive export
#3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmih
requested review from
hanabi1224 and
aatifsyed
and removed request for
a team
hanabi1224
reviewed
Jul 31, 2023
| } | ||
| } | ||
|
|
||
| pub fn stream_graph<DB: Blockstore, T: Iterator<Item = Tipset> + Unpin>( |
There was a problem hiding this comment.
Any way to indicate fail_on_dead_links: false in the function name or doc? e.g. stream_graph_unstrict
There was a problem hiding this comment.
I've updated the documentation of both stream_graph and stream_chain.
hanabi1224
reviewed
Jul 31, 2023
| @@ -69,6 +72,9 @@ pub enum ArchiveCommands { | |||
| /// How many state-roots to include. Lower limit is 900 for `calibnet` and `mainnet`. | |||
| #[arg(short, long, default_value_t = 2000)] | |||
| depth: ChainEpochDelta, | |||
| /// Do not include any values reachable from this epoch | |||
| #[arg(short, long)] | |||
| diff: Option<ChainEpochDelta>, | |||
There was a problem hiding this comment.
It's a bit confusing, doc says epoch while code says epoch delta
There was a problem hiding this comment.
Updated to epoch-diff.
hanabi1224
reviewed
Jul 31, 2023
| .context("diff epoch must be smaller than target epoch")?; | ||
| let diff_ts: &Tipset = &diff_ts; | ||
| let mut stream = stream_graph(&store, diff_ts.clone().chain(&store)); | ||
| while stream.try_next().await?.is_some() {} |
There was a problem hiding this comment.
Does it make sense to warn in into_seen when the stream is not fully consumed or move stream consuming logic into into_seen?
There was a problem hiding this comment.
You don't always want to consume the entire stream.
hanabi1224
approved these changes
Jul 31, 2023
4 tasks
LesnyRumcajs
approved these changes
Jul 31, 2023
sudo-shashank
pushed a commit
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
--diffflag for exporting the set difference of two snapshots.Reference issue to close (if applicable)
Closes #3204
Other information and links
Change checklist