Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bigint serialization utils #331

Merged
merged 8 commits into from
Apr 7, 2020
Merged

Move bigint serialization utils #331

merged 8 commits into from
Apr 7, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Apr 3, 2020

Summary of changes
Changes introduced in this pull request:

  • moves bigint serialization to utils folder
    • I noticed the wrapper types serialization could be derived with self:: instead of that manual impl when doing this, so I made that change too for readability
  • removes unused dev dependencies
  • Adds Bytes serde wrappers (cleaner than going through ByteBuf and I found I mistyped .to_vec() instead of .into_vec() in a couple cases which is an unnecessary clone). This just makes usage easier and cleaner for the future.
    • Originally just wanted to add the serde(transparent) tag for cleaner expanded serde derivation, but then I noticed the other things
    • Also cleaned up other serde impls that I noticed

Just a couple small things that were bugging me and I wanted to clean up

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit ca7898f into master Apr 7, 2020
@austinabell austinabell deleted the austin/movebigintser branch April 7, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants