Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reduce car cache from 2GiB to 1GiB #3310

Merged
merged 3 commits into from
Aug 2, 2023
Merged

chore: reduce car cache from 2GiB to 1GiB #3310

merged 3 commits into from
Aug 2, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Aug 2, 2023 •
edited

Summary of changes

Changes introduced in this pull request:

  • Reduce cache of z-frames from 2GiB to 1GiB.

Benchmarks in #3288 showed that there's little benefit to using a large cache. Going from 2GiB to 1GiB should have no impact on performance but will lessen the memory strain.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review August 2, 2023 08:33
@lemmih lemmih requested a review from a team as a code owner August 2, 2023 08:33
@lemmih lemmih requested review from LesnyRumcajs and jdjaustin and removed request for a team August 2, 2023 08:33
@lemmih lemmih added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit a2b3269 Aug 2, 2023
20 checks passed
@lemmih lemmih deleted the lemmih/reduce-car-cache branch August 2, 2023 12:14
sudo-shashank pushed a commit that referenced this pull request Aug 3, 2023
@lemmih @sudo-shashank
chore: reduce car cache from 2GiB to 1GiB (#3310)
ab19a10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@jdjaustin jdjaustin Awaiting requested review from jdjaustin jdjaustin is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lemmih @hanabi1224 @LesnyRumcajs