-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add forest-tool benchmark
command
#3316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. A simple framework we can iterate on going forward.
Some general thoughts for future work:
Though I think right now the current framework is more than sufficient, introducing more benchmarks seems to be of higher priority than any of these enhancements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this built and run as part of the CI? Even in the minimal form (with some small CAR-files), it'd be good to have the execution path covered.
All in all, fantastic work.
I'll open a follow-up PR. |
Summary of changes
Changes introduced in this pull request:
forest-tool
binary.forest-tool benchmark
command.Reference issue to close (if applicable)
Closes
Other information and links
Change checklist