Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add forest-tool benchmark command #3316

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Aug 3, 2023

Summary of changes

Changes introduced in this pull request:

  • introduce new forest-tool binary.
  • add forest-tool benchmark command.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review August 3, 2023 08:44
@lemmih lemmih requested a review from a team as a code owner August 3, 2023 08:44
@lemmih lemmih requested review from LesnyRumcajs and sudo-shashank and removed request for a team August 3, 2023 08:44
Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. A simple framework we can iterate on going forward.

@ruseinov
Copy link
Contributor

ruseinov commented Aug 3, 2023

Some general thoughts for future work:

  1. We could enhance this with some nice additional features going forward, like running a benchmark several times (tries) and taking average values.
  2. Some inspiration could be taken from other benchmarking frameworks, for example this of Parity Substrate.

Though I think right now the current framework is more than sufficient, introducing more benchmarks seems to be of higher priority than any of these enhancements.

Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this built and run as part of the CI? Even in the minimal form (with some small CAR-files), it'd be good to have the execution path covered.

All in all, fantastic work.

@lemmih
Copy link
Contributor Author

lemmih commented Aug 3, 2023

Is this built and run as part of the CI? Even in the minimal form (with some small CAR-files), it'd be good to have the execution path covered.

All in all, fantastic work.

I'll open a follow-up PR.

@lemmih lemmih added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 2487672 Aug 3, 2023
20 checks passed
@lemmih lemmih deleted the lemmih/forest-tool-benchmark branch August 3, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants