Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow streaming of CAR.zst files with multiple frames #3319

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Aug 3, 2023

Summary of changes

Changes introduced in this pull request:

  • multiple frames are disallowed by default but we need them for the ForestCAR.zst format.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we know if at affects anything rather than accepting multiple frames?

@lemmih
Copy link
Contributor Author

lemmih commented Aug 3, 2023

Looks good. Do we know if at affects anything rather than accepting multiple frames?

It shouldn't. It just toggles whether the decoder ends after a single frame. The async-compression library enables it by default, so we didn't notice the problem before now.

@lemmih lemmih marked this pull request as ready for review August 3, 2023 12:07
@lemmih lemmih requested a review from a team as a code owner August 3, 2023 12:07
@lemmih lemmih requested review from hanabi1224 and aatifsyed and removed request for a team August 3, 2023 12:07
@lemmih lemmih added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit d6e494a Aug 3, 2023
23 checks passed
@lemmih lemmih deleted the lemmih/fix-multipart-car-stream branch August 3, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants