Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --depth flag to snapshot export #3330

Merged
merged 6 commits into from
Aug 9, 2023
Merged

feat: add --depth flag to snapshot export #3330

merged 6 commits into from
Aug 9, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Aug 7, 2023 •
edited

Summary of changes

Changes introduced in this pull request:

  • A depth of 2000 is the default but other depths are useful. This PR adds a flag to using a custom depth when exporting.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review August 7, 2023 09:36
@lemmih lemmih requested a review from a team as a code owner August 7, 2023 09:36
@lemmih lemmih requested review from jdjaustin and elmattic and removed request for a team August 7, 2023 09:36
jdjaustin
jdjaustin suggested changes Aug 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lemmih and others added 2 commits August 8, 2023 10:32
@lemmih @jdjaustin
fix brain fart in changelog
ad5cbf6 
Co-authored-by: Josh Jones <joshua.jones@chainsafe.io>
@lemmih
warn if exporting with too few tipsets
0daa365
@lemmih lemmih requested a review from jdjaustin August 8, 2023 08:35
@lemmih lemmih added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
@lemmih lemmih added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
LesnyRumcajs
LesnyRumcajs approved these changes Aug 9, 2023
View reviewed changes
src/cli/subcommands/snapshot_cmd.rs Outdated Show resolved Hide resolved
@lemmih @LesnyRumcajs
Update src/cli/subcommands/snapshot_cmd.rs
10a185e 
Co-authored-by: Hubert <hubert@chainsafe.io>
@lemmih lemmih added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit 9e34264 Aug 9, 2023
20 checks passed
@lemmih lemmih deleted the lemmih/export-depth-flag branch August 9, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruseinov ruseinov ruseinov approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@jdjaustin jdjaustin jdjaustin approved these changes

@elmattic elmattic Awaiting requested review from elmattic elmattic is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lemmih @ruseinov @LesnyRumcajs @jdjaustin