Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy-paste deserialize code from serde_ipld_dagcbor #3332

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Aug 7, 2023

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the fallback-cbor-decode branch 3 times, most recently from ca904ca to cf487dc Compare August 7, 2023 11:55
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review August 7, 2023 14:12
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner August 7, 2023 14:12
@LesnyRumcajs LesnyRumcajs requested review from ruseinov and hanabi1224 and removed request for a team August 7, 2023 14:12
Copy link
Contributor

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Let's add a changelog entry saying we now correctly parse data from before epoch 1_960_320.

Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Aug 7, 2023
Merged via the queue into main with commit 10896c2 Aug 7, 2023
20 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fallback-cbor-decode branch August 7, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants