Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default RPC port #3333

Merged
merged 7 commits into from
Aug 9, 2023
Merged

Change default RPC port #3333

merged 7 commits into from
Aug 9, 2023

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Aug 7, 2023

Summary of changes

Changes introduced in this pull request:

  • Change default RPC port from 1234 to 2345

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review August 8, 2023 07:35
@elmattic elmattic requested a review from a team as a code owner August 8, 2023 07:35
@elmattic elmattic requested review from LesnyRumcajs and jdjaustin and removed request for a team August 8, 2023 07:35
@lemmih
Copy link
Contributor

lemmih commented Aug 8, 2023

@samuelarogbonlo We'll have to update forest-iac as well.

Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mark it as a breaking change.

@elmattic
Copy link
Contributor Author

elmattic commented Aug 8, 2023

Let's mark it as a breaking change.

Where else should I do it? In the CHANGELOG it's in the ### Breaking section.

@LesnyRumcajs
Copy link
Member

Let's mark it as a breaking change.

Where else should I do it? In the CHANGELOG it's in the ### Breaking section.

Ah, right, I didn't notice it. All good then.

@samuelarogbonlo
Copy link

@samuelarogbonlo We'll have to update forest-iac as well.

sure!.

@elmattic elmattic added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
@elmattic elmattic added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit cccfdc3 Aug 9, 2023
20 checks passed
@elmattic elmattic deleted the elmattic/change-default-rpc-port branch August 9, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants