Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag for limiting the diff depth of snapshots #3348

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Aug 9, 2023

Summary of changes

Changes introduced in this pull request:

  • Add --diff-depth flag to forest-cli archive export. All values reachable in the diff depth will not be included in diff snapshots.
  • Fix type of diff from ChainEpochDelta to ChainEpoch.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih
Copy link
Contributor Author

lemmih commented Aug 9, 2023

I am not sure how to test this code.

@lemmih lemmih marked this pull request as ready for review August 9, 2023 13:29
@lemmih lemmih requested a review from a team as a code owner August 9, 2023 13:29
@lemmih lemmih requested review from creativcoder and hanabi1224 and removed request for a team August 9, 2023 13:29
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit c0eeeab Aug 9, 2023
23 checks passed
@LesnyRumcajs LesnyRumcajs deleted the lemmih/add-diff-depth branch August 9, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants