forest-cli db subcommands migration
#3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmattic
changed the title
forest-cli db subcommands migration
elmattic
force-pushed
the
elmattic/db-cmds-tool-migration
branch
from
0781d4b
to
b335cfe
Compare
…into elmattic/db-cmds-tool-migration
elmattic
requested review from
LesnyRumcajs and
aatifsyed
and removed request for
a team
aatifsyed
approved these changes
Aug 11, 2023
LesnyRumcajs
approved these changes
Aug 11, 2023
| @@ -24,6 +24,13 @@ macro_rules! bail_moved_cmd { | |||
| $src | |||
| ) | |||
| }; | |||
| ($src:literal, $dst:literal) => { | |||
There was a problem hiding this comment.
why does it have to be a macro?
There was a problem hiding this comment.
Just a personal preference here. At some point I believe this code will be deleted anyway, once users have migrated to the new binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
forest-cli db statstoforest-tool db statsforest-cli db cleantoforest-tool db destroyReference issue to close (if applicable)
Closes
Other information and links
Change checklist