Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor error handling #336

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Refactor error handling #336

merged 3 commits into from
Apr 8, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Apr 8, 2020

Summary of changes
Changes introduced in this pull request:

  • Been bugging me for a while now, and now seemed like a good time to change because less conflicts

There are still things I think could be improved, but I tried to keep these changes unopinionated without making any functional changes.

Only functional changes are two things I suspect to be bugs here if that doesn't resolve, the change(s) in chain_store.rs @dutterbutter can you confirm there isn't a specific reason it should not change

Reference issue to close (if applicable)

Closes
#216

Other information and links

@dutterbutter
Copy link
Contributor

@austinabell yes that should return Ok(()) rather than an error. Nice catch!

@austinabell austinabell merged commit f5845a0 into master Apr 8, 2020
@austinabell austinabell deleted the austin/errorrefactor branch April 8, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants