Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forest-cli wallet subcommands migration #3362

Merged
merged 20 commits into from
Aug 18, 2023
Merged

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Aug 11, 2023

Summary of changes

Changes introduced in this pull request:

  • Moved the following forest-cli wallet subcommands to forest-wallet

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review August 14, 2023 10:10
@elmattic elmattic requested a review from a team as a code owner August 14, 2023 10:10
@elmattic elmattic requested review from creativcoder and jdjaustin and removed request for a team August 14, 2023 10:10
src/cli_shared/cli/mod.rs Outdated Show resolved Hide resolved
src/wallet/main.rs Outdated Show resolved Hide resolved
@LesnyRumcajs
Copy link
Member

I don't quite understand. What benefit does moving forest-cli wallet to forest-wallet bring? I mean, the keys are still governed by the Forest node. To my understanding, the goal was to have better key security by decoupling it completely from the Forest node. See #2274

@elmattic
Copy link
Contributor Author

I don't quite understand. What benefit does moving forest-cli wallet to forest-wallet bring? I mean, the keys are still governed by the Forest node. To my understanding, the goal was to have better key security by decoupling it completely from the Forest node. See #2274

I think it's the end goal. And moving commands to a new standalone binary is a first step.

@elmattic elmattic added this pull request to the merge queue Aug 18, 2023
@elmattic elmattic removed this pull request from the merge queue due to a manual request Aug 18, 2023
@elmattic elmattic added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit a2a800e Aug 18, 2023
21 checks passed
@elmattic elmattic deleted the elmattic/wallet-cmds-migration branch August 18, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants