Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect remaining Actor invocations to runtime and cleanup #342

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Connect remaining Actor invocations to runtime and cleanup #342

merged 2 commits into from
Apr 13, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Market actor implementation #338 came in and didn't notice until after it wasn't connected to runtime so did that and also connected a base miner actor so on that implementation the changes are more contained
  • Cleaned up things I noticed along the way and fixed some exit codes I noticed
    • Noticed other things I wanted to fix, but changes ended up being too extensive and breaking so will leave for another PR and left a few TODOs of for sure broken things

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 8f8fd1e into master Apr 13, 2020
@austinabell austinabell deleted the austin/vm/connectactors branch April 13, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@ec2 ec2 Awaiting requested review from ec2

Assignees
No one assigned
Labels
Status: Needs Review VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@austinabell @dutterbutter