Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forest-cli snapshot compress subcommand migration #3431

Merged
merged 5 commits into from
Sep 1, 2023
Merged

forest-cli snapshot compress subcommand migration #3431

merged 5 commits into from
Sep 1, 2023

Conversation

elmattic
Copy link
Contributor

Summary of changes

Changes introduced in this pull request:

  • Move snapshot compress subcommand to forest-tool

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review August 31, 2023 15:28
@elmattic elmattic requested a review from a team as a code owner August 31, 2023 15:28
@elmattic elmattic requested review from ruseinov and hanabi1224 and removed request for a team August 31, 2023 15:28
hanabi1224
hanabi1224 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@hanabi1224 hanabi1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some CI coverage for this feature? to forest_tool_check.sh.

@elmattic
Copy link
Contributor Author

elmattic commented Sep 1, 2023

forest_tool_check

We should add it more in gen_coverage_report.sh, no?

@hanabi1224
Copy link
Contributor

Sorry I meant test coverage but it will be great to also have code coverage if feasible

@lemmih lemmih added this pull request to the merge queue Sep 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 1, 2023
@elmattic elmattic force-pushed the elmattic/compress-cmd-tool-migration branch from 84e5aae to 3a6b16b Compare September 1, 2023 10:56
@elmattic
Copy link
Contributor Author

elmattic commented Sep 1, 2023

Sorry I meant test coverage but it will be great to also have code coverage if feasible

Will add both in a subsequent PR.

@elmattic elmattic added this pull request to the merge queue Sep 1, 2023
Merged via the queue into main with commit 9dbeee3 Sep 1, 2023
23 checks passed
@elmattic elmattic deleted the elmattic/compress-cmd-tool-migration branch September 1, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elmattic @hanabi1224 @lemmih