Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forest-cli archive export/ checkpoints subcommands migration #3432

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

elmattic
Copy link
Contributor

Summary of changes

Changes introduced in this pull request:

  • Move remaining archive subcommands to forest-tool

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review August 31, 2023 15:28
@elmattic elmattic requested a review from a team as a code owner August 31, 2023 15:28
@elmattic elmattic requested review from lemmih and sudo-shashank and removed request for a team August 31, 2023 15:28
@elmattic
Copy link
Contributor Author

elmattic commented Aug 31, 2023

Not sure why importing_bad_snapshot_should_fail test is failing and if I can ignore this and just re-run the job.
Locally the test was failing as well, then re-running it again it's now passing ✅.

@LesnyRumcajs
Copy link
Member

@elmattic what was the failure for the test? It should not be flaky at all.

@elmattic
Copy link
Contributor Author

elmattic commented Sep 1, 2023

@elmattic what was the failure for the test? It should not be flaky at all.

Test was too slow and resulted in a time out.

@LesnyRumcajs
Copy link
Member

@elmattic what was the failure for the test? It should not be flaky at all.

Test was too slow and resulted in a time out.

Let's create an issue if it happens more often.

@elmattic elmattic added this pull request to the merge queue Sep 1, 2023
Merged via the queue into main with commit 1f1710e Sep 1, 2023
23 checks passed
@elmattic elmattic deleted the elmattic/archive-cmds-tool-migration branch September 1, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants