feat: add `--consume-snapshot` to `forest` daemon #3439

hanabi1224 · 2023-09-01T08:27:41Z

Summary of changes

This PR tries to implement below feature decribed in #3334

Add flag --consume-snapshot. It should do the same as --import-snapshot, but it'll move or delete the snapshot.

Changes introduced in this pull request:

Closes #3334

I have performed a self-review of my own code,
I have made corresponding changes to the documentation,
I have added tests that prove my fix is effective or that my feature works (if possible),
I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

lemmih

Hmm, I have no idea what --import-chain does.

hanabi1224 added 2 commits September 1, 2023 16:25

feat: add --consume-snapshot to forest

228ee73

changelog

9ca4733

hanabi1224 marked this pull request as ready for review September 1, 2023 08:32

hanabi1224 requested a review from a team as a code owner September 1, 2023 08:32

hanabi1224 requested review from lemmih and jdjaustin and removed request for a team September 1, 2023 08:32

fix spellcheck

ab922d4

lemmih approved these changes Sep 1, 2023

View reviewed changes

jdjaustin approved these changes Sep 1, 2023

View reviewed changes

hanabi1224 added 2 commits September 1, 2023 17:48

cleanup stale TODO

83ee31c

Merge branch 'main' into hm/consume-snapshot

e842c2e

hanabi1224 enabled auto-merge September 1, 2023 09:50

hanabi1224 added this pull request to the merge queue Sep 1, 2023

Merged via the queue into main with commit 9721545 Sep 1, 2023
23 checks passed

hanabi1224 deleted the hm/consume-snapshot branch September 1, 2023 10:51

elmattic pushed a commit that referenced this pull request Sep 1, 2023

feat: add --consume-snapshot to forest daemon (#3439)

84e5aae