Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: command for merging snapshot files #3462

Merged
merged 5 commits into from
Sep 8, 2023
Merged

feat: command for merging snapshot files #3462

merged 5 commits into from
Sep 8, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Sep 5, 2023 •
edited

Summary of changes

Changes introduced in this pull request:

  • add forest-tool archive merge.
  • this command is similar to forest-tool car union but outputs a valid Filecoin snapshot.
  • testing left as an exercise for the reader. Tracking issue: Re-consider how to test diff snapshots #3347

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review September 5, 2023 14:40
@lemmih lemmih requested a review from a team as a code owner September 5, 2023 14:40
@lemmih lemmih requested review from ruseinov and elmattic and removed request for a team September 5, 2023 14:40
ruseinov
ruseinov reviewed Sep 7, 2023
View reviewed changes
src/tool/subcommands/archive_cmd.rs
)?);

// Stream all available blocks from heaviest_tipset to genesis.
let blocks = stream_graph(&store, heaviest_tipset.chain(&store), 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is it the intention here to ignore dead links? Otherwise looks good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, dead links should be ignored.

ruseinov
ruseinov approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, except one clarification.

@elmattic elmattic added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit 1bc3dce Sep 8, 2023
26 checks passed
@elmattic elmattic deleted the lemmih/tool-archive-merge branch September 8, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruseinov ruseinov ruseinov approved these changes

@elmattic elmattic elmattic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lemmih @ruseinov @elmattic