Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement verify signature syscall and cleanup #351

Merged
merged 6 commits into from
Apr 16, 2020

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Apr 15, 2020

Summary of changes
Changes introduced in this pull request:

  • Implements verify sig syscall verify signature syscall #301
    • Removes duplicate error when syscalls are called in actors
      • (I don't actually think the out of gas exit code can be hit within the actors and maybe that is intentional)
  • Crypto crate cleanup
    • A lot was setup to try to match spec 1:1 and old implementation when possible, so now more closely matches impls and cleaner interface in rust
    • Signature verification now also returns result instead of just a boolean, for better error reporting

Reference issue to close (if applicable)

Closes
#301

Other information and links

let parent_tipset = base_tipset.tipset()?;

println!("BEFORE TIME STAMP VALIDATIONS");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehehe

}
}

/// Returns true if a secp256k1 signature is valid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misleading comment as it does not return bool?

@austinabell austinabell merged commit 1e6533a into master Apr 16, 2020
@austinabell austinabell deleted the austin/syscalls/vsig branch April 16, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants