Implements apply_message and apply_implicit_message #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored return err messages
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
austinabell
reviewed
Apr 15, 2020
Co-Authored-By: Austin Abell <austinabell8@gmail.com>
austinabell
suggested changes
Apr 15, 2020
austinabell
suggested changes
Apr 16, 2020
austinabell
approved these changes
Apr 16, 2020
ec2
reviewed
Apr 16, 2020
| ) -> ( | ||
| Serialized, | ||
| DefaultRuntime<'_, 'm, '_, ST, DB, SYS>, | ||
| Option<ActorError>, |
There was a problem hiding this comment.
Don't understand why this is an option? If internal_send is successful, we can return ExitCode::Ok, otherwise return actor_err, no?
There was a problem hiding this comment.
It seems weird to construct an error upon a successful call. More preference I suppose.
ec2
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
apply_messageapply_implicit_messagesendto return a tuplesyscallsto VM structI noticed in the spec they are applying a
network_tx_feetototal_costwhich is checked against thefrom_actorsbalance to see if there are sufficient funds. I added a TODO for this, however, I am not sure what thatnetwork_tx_feeis comprised of.Additionally, I added
apply_implicit_messageas it exists in the lotus implementation, but I do not seeapply_tipset_messagesin the implementation anymore. I did not remove it from our implementation as it seems that it will be required?Reference issue to close (if applicable)
Closes #340
Other information and links