Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow default Cid and Address serialization #354

Merged
merged 4 commits into from
Apr 17, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Just a sanity check as we get to the point of running a node
    • Default is only really needed out of convenience and for testing, but erroring on attempting to serialize either enforces that this default structs do not get used in any meaningful way.
    • Just makes debugging any potential bug relating to this easier as it will silently allow using the defaults currently

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell merged commit 3798a4e into master Apr 17, 2020
@austinabell austinabell deleted the austin/defaultsanitychecks branch April 17, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants