Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock Runtime and tests for Account and Cron Actors #356

Merged
merged 36 commits into from
Apr 20, 2020
Merged

Mock Runtime and tests for Account and Cron Actors #356

merged 36 commits into from
Apr 20, 2020

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Apr 17, 2020 •
edited

Summary of changes
Changes introduced in this pull request:

  • Mock Runtime for Actors testing
  • Implement tests for: Account, Cron actors based on tests in specs-actor

Reference issue to close (if applicable)

Closes
#312, #319, #349

Other information and links

dutterbutter and others added 21 commits April 8, 2020 16:53
@dutterbutter
wip market actor continued
b7b959c
@dutterbutter
Merge branch 'master' of github.com:ChainSafe/forest into dustin/mark…
dc0f07a 
…et-actor
@dutterbutter
market actor implementation methods in place
65e92a0
@dutterbutter
market actor implemented
2082c39
@dutterbutter
removed unneeded serialization
382e708
@dutterbutter
hot fix
40ae027
@dutterbutter
Added actor code trait
342682e
@dutterbutter
Merge branch 'master' into dustin/market-actor
5ff1819
@dutterbutter
initial changes requested
3e6a058
@dutterbutter
Merge branch 'dustin/market-actor' of github.com:ChainSafe/forest int…
ed79520 
…o dustin/market-actor
@dutterbutter
resolve changes
5c6ccee
@dutterbutter
Updated single value serialization
af4dd79
@ec2
basic mock rt
f4005e2
@ec2
partially working WIP
d949b79
@ec2
Merge branch 'master' into ec2/mock-rt
801587a
@ec2
one case done
96a37bf
@ec2
one more test
41c8ce3
@ec2
cron actor
a2206ef
@ec2
made tests more beautiful
40db53f
@ec2
Merge branch 'master' into ec2/mock-rt
da6826a
@ec2
license
aeabdbe
@ec2
Copy link
Member Author

ec2 commented Apr 17, 2020

I wrote a macro!

austinabell
austinabell suggested changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to remove the changes to the serialization vectors submodule you made in this

vm/actor/tests/account_actor_test.rs Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/cron_actor_test.rs Outdated Show resolved Hide resolved
vm/actor/tests/cron_actor_test.rs Outdated Show resolved Hide resolved
@ec2 ec2 requested a review from austinabell April 17, 2020 18:54
This was linked to issues Apr 17, 2020
Port over tests for CronActor #312
Closed
Implement Mock Runtime for testing #319
Closed
Port over tests for Account Actor #349
Closed
austinabell
austinabell suggested changes Apr 17, 2020
View reviewed changes
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
@ec2 ec2 requested a review from austinabell April 20, 2020 04:28
dutterbutter
dutterbutter reviewed Apr 20, 2020
View reviewed changes
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/account/mod.rs Outdated Show resolved Hide resolved
vm/actor/tests/account_actor_test.rs Outdated Show resolved Hide resolved
vm/actor/tests/common/mod.rs Show resolved Hide resolved
@ec2 ec2 merged commit 4382a82 into master Apr 20, 2020
@ec2 ec2 deleted the ec2/mock-rt branch April 20, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ansermino ansermino Awaiting requested review from ansermino

Assignees
No one assigned
Labels
Status: Merge Ready VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port over tests for Account Actor Implement Mock Runtime for testing Port over tests for CronActor
3 participants
@ec2 @austinabell @dutterbutter