Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't drop colliding keys from ForestCAR #3590

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Oct 13, 2023

Summary of changes

Changes introduced in this pull request:

  • When gathering the mapping from hash to zstd frame offset, use a vector rather than a hashmap. Colliding hashes should be able to point to different zstd frames.

There is a small chance some of the archival ForestCAR files are invalid. Fortunately, it is easy to verify. I'll re-scan the files and re-generate any broken archives.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review October 13, 2023 09:51
@lemmih lemmih requested a review from a team as a code owner October 13, 2023 09:51
@lemmih lemmih requested review from jdjaustin and elmattic and removed request for a team October 13, 2023 09:51
@lemmih lemmih requested a review from aatifsyed October 13, 2023 10:20
@lemmih lemmih added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 7f912a7 Oct 13, 2023
23 checks passed
@lemmih lemmih deleted the lemmih/fix-collision-bug-in-car-encoder branch October 13, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants