feat: add --stateless flag to forest
#3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
force-pushed
the
hm/stateless-mode
branch
from
4743c2c
to
6547bfb
Compare
4 tasks
4 tasks
hanabi1224
requested review from
lemmih and
LesnyRumcajs
and removed request for
a team
lemmih
reviewed
Oct 20, 2023
lemmih
reviewed
Oct 23, 2023
hanabi1224
force-pushed
the
hm/stateless-mode
branch
from
dbc679f
to
bf299f9
Compare
4 tasks
LesnyRumcajs
approved these changes
Oct 30, 2023
| @@ -65,6 +65,8 @@ | |||
|
|
|||
| - [#3422](https://github.com/ChainSafe/forest/issues/3422) Add NV21 (Watermelon) | |||
| support for calibration network. | |||
| - [#3593](https://github.com/ChainSafe/forest/pull/3593): Add `--stateless` flag | |||
There was a problem hiding this comment.
Is it worth elaborating a bit on what this flag exactly does?
|
|
||
| STATELESS_NODE_ADDRESS=$($FOREST_CLI_PATH net listen | tail -n 1) | ||
| echo "Stateless node address: $STATELESS_NODE_ADDRESS" | ||
| STATELESS_NODE_PEER_ID=$(echo "$STATELESS_NODE_ADDRESS" | cut --delimiter="/" --fields=7 --zero-terminated) |
There was a problem hiding this comment.
It might be worth commenting on an expected format with an example multiaddress.
| EOF | ||
|
|
||
| # Disable discovery to not connect to more nodes | ||
| $FOREST_PATH --chain calibnet --encrypt-keystore false --auto-download-snapshot --config "$CONFIG_PATH" --rpc false --mdns false --kademlia false --metrics-address 127.0.0.1:6117 & |
There was a problem hiding this comment.
Could we disable mdns and kademlia in config? Unless you think passing it as flags makes more sense.
There was a problem hiding this comment.
I've no preference, fixed as suggested
|
|
||
| source "$(dirname "$0")/harness.sh" | ||
|
|
||
| forest_init_stateless |
There was a problem hiding this comment.
Will this node be killed in case of an error somewhere along the way?
There was a problem hiding this comment.
Yes the detached node will be killed by trap forest_cleanup EXIT in harness.sh
lemmih
approved these changes
Oct 30, 2023
LesnyRumcajs
approved these changes
Oct 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
LesnyRumcajs
added a commit
that referenced
this pull request
Nov 1, 2023
This reverts commit 952a63e.
LesnyRumcajs
added a commit
that referenced
this pull request
Dec 13, 2023
)" This reverts commit 8d6a84c.
LesnyRumcajs
added a commit
that referenced
this pull request
Dec 13, 2023
)" This reverts commit 8d6a84c.
LesnyRumcajs
added a commit
that referenced
this pull request
Dec 14, 2023
)" This reverts commit 8d6a84c.
LesnyRumcajs
added a commit
that referenced
this pull request
Dec 14, 2023
)" This reverts commit 8d6a84c.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As part of #3556
Changes introduced in this pull request:
If a block is requested that we do not have, forward the request to other peers and cache the result.We don't forward the request as discussed hereReference issue to close (if applicable)
Closes
Other information and links
Change checklist