Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/fix: simplify configuration for forest-cli #3613

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Oct 19, 2023

Summary of changes

Changes introduced in this pull request:

  • Remove the Config and Client structures from the forest-cli command-line handling.
  • Add --expire-in flags to forest-cli auth create-token and forest-cli auth api-info commands.
  • Move finality out of the client. The node is responsible for correctness.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review October 19, 2023 13:32
@lemmih lemmih requested a review from a team as a code owner October 19, 2023 13:32
@lemmih lemmih requested review from ruseinov and hanabi1224 and removed request for a team October 19, 2023 13:32
@lemmih lemmih enabled auto-merge October 23, 2023 13:24
@lemmih lemmih added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 70a98ae Oct 23, 2023
23 checks passed
@lemmih lemmih deleted the lemmih/simpliy-forest-cli-config branch October 23, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants