Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove chain section from forest config #3615

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 20, 2023

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review October 20, 2023 06:52
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 20, 2023 06:52
@hanabi1224 hanabi1224 requested review from lemmih and sudo-shashank and removed request for a team October 20, 2023 06:52
Copy link
Contributor

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to set the chain in the configuration file, but maybe that can come later.

Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an entry in the CHANGELOG.

@hanabi1224
Copy link
Contributor Author

Let's add an entry in the CHANGELOG.

@LesnyRumcajs Done.
(And please re-approve if the change looks OK)

@hanabi1224 hanabi1224 added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit 949315a Oct 24, 2023
24 checks passed
@hanabi1224 hanabi1224 deleted the hm/remove-chain-section-from-config branch October 24, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants