Stmgr retrieval methods + is_ticket_winner calc for block validation #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added is_Ticket_winner calc * Updated block validation checks to reflect changes
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
austinabell
suggested changes
Apr 21, 2020
austinabell
reviewed
Apr 22, 2020
austinabell
approved these changes
Apr 22, 2020
ec2
reviewed
Apr 23, 2020
…to dustin/stmgr-getters
ec2
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
StateManagercomponent which are used during block validation inChainSynceris_ticket_winnercalc toBlockHeaderwhich is used during block validation inChainSyncerresolve_to_key_addroutside ofDefaultRuntimeReference issue to close (if applicable)
Closes #361 Closes #362 Closes #365
Other information and links