Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message and messageReceipt to block #37

Merged
merged 5 commits into from
Nov 27, 2019
Merged

Conversation

GregTheGreek
Copy link
Member

No description provided.

dutterbutter
dutterbutter previously approved these changes Nov 26, 2019
austinabell
austinabell previously approved these changes Nov 26, 2019
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it this time, but please keep your PRs smaller next time ;)

ec2
ec2 previously approved these changes Nov 26, 2019
@dutterbutter
Copy link
Contributor

dutterbutter commented Nov 26, 2019

@GregTheGreek looks like they updated the spec and removed receipts from the block structure...please update

@GregTheGreek
Copy link
Member Author

Looks like signedBlock was also removed in this pr along side the receipts

@GregTheGreek
Copy link
Member Author

@dutterbutter forgot to push..

@GregTheGreek GregTheGreek dismissed stale reviews from ec2, austinabell, and dutterbutter November 27, 2019 06:40

old spec version

@GregTheGreek GregTheGreek merged commit dc04a06 into master Nov 27, 2019
@GregTheGreek GregTheGreek deleted the greg/blockchain/blocks branch November 27, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants