Added bls aggregate sig check for block validation #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
ec2
reviewed
Apr 23, 2020
austinabell
reviewed
Apr 23, 2020
ec2
approved these changes
Apr 24, 2020
austinabell
approved these changes
Apr 24, 2020
| @@ -83,4 +83,17 @@ where | |||
| )) | |||
| } | |||
| } | |||
| /// Returns a bls public key from provided address | |||
| pub fn get_bls_public_key(&self, addr: &Address, state_cid: &Cid) -> Result<Vec<u8>, Error> { | |||
There was a problem hiding this comment.
Just a note that the public key should probably be an array (I'll make a pass through the Address crate soon I guess)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
get_bls_public_keymethodReference issue to close (if applicable)
Closes #215
Other information and links