Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --n-tipsets option to forest-tool api compare #3737

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Nov 23, 2023

Summary of changes

This PR tries to address

Right now, only the last 20 tipsets are used. It would be nice to sample a greater range.

Changes introduced in this pull request:

  • add --n-tipsets option to forest-tool api compare to allow customizing the number of tipsets to test against

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review November 23, 2023 07:24
@hanabi1224 hanabi1224 requested a review from a team as a code owner November 23, 2023 07:24
@hanabi1224 hanabi1224 requested review from ruseinov and sudo-shashank and removed request for a team November 23, 2023 07:24
@hanabi1224 hanabi1224 added this pull request to the merge queue Nov 23, 2023
@hanabi1224 hanabi1224 changed the title feat: add --n-tipsets option to forest-tool api compre feat: add --n-tipsets option to forest-tool api compare Nov 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2023
@hanabi1224 hanabi1224 added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit 09a42ca Nov 23, 2023
60 checks passed
@hanabi1224 hanabi1224 deleted the hm/api-compare-n-tipsets branch November 23, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants