Apply Blocks and refactor #374
Conversation
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
| self.blocks | ||
| } | ||
| // TODO: conversions from full to regular tipset should not return a result | ||
| // and should be validated on creation instead |
There was a problem hiding this comment.
What validations should be checked? The tipset constructor has validation checks included but curious what other validation would be required?
There was a problem hiding this comment.
The Tipset does yeah, but the FullTipset is sometimes constructed without validation (why the conversion to Tipset is error prone
ipld/blockstore/src/buffered.rs
Outdated
| use std::error::Error as StdError; | ||
|
|
||
| /// Wrapper around `BlockStore` to limit and have control over when values are written. | ||
| /// This type is not threadsafe and can only be used in syncronous contexts. |
ipld/blockstore/src/buffered.rs
Outdated
|
|
||
| impl<'bs, BS> BufferedBlockStore<'bs, BS> | ||
| where | ||
| BS: BlockStore + Store, |
There was a problem hiding this comment.
Curious what are the consequences of removing the requirement of Store on BS, since BlockStore inherets the Store trait... I removed it and it works.
There was a problem hiding this comment.
functionally the same, but yeah should be more succinct, I'll fix
There was a problem hiding this comment.
Cool. Just wanted to make sure i was on the same page. But yeah, removing is best
Summary of changes
Changes introduced in this pull request:
Refactor and cleanup:
Reference issue to close (if applicable)
Closes
#363
Other information and links