Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duration to snapshot compute-state json output #3748

Merged
merged 11 commits into from
Nov 30, 2023

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Nov 27, 2023

Summary of changes

Changes introduced in this pull request:

  • Add timing for each message and gas charge in the JSON output

Timings are expressed in nanoseconds. You should see results of the same magnitude as Lotus, for example, when the following commands are used:

lotus state compute-state --json --vm-height <height>
forest-tool snapshot compute-state --epoch <height> --json <snapshot>

Only fvm4 is supported at the moment because of #3524.

Sample output

forest-tool snapshot compute-state --epoch 1131010 --json forest_snapshot_calibnet_2023-11-29_height_1131010.forest.car.zst | jq > compute-state.log

compute-state.log

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review November 29, 2023 10:40
@elmattic elmattic requested a review from a team as a code owner November 29, 2023 10:40
@elmattic elmattic requested review from hanabi1224 and LesnyRumcajs and removed request for a team November 29, 2023 10:40
@LesnyRumcajs
Copy link
Member

Could you please add a sample output?

@elmattic
Copy link
Contributor Author

Could you please add a sample output?

Done.

@lemmih
Copy link
Contributor

lemmih commented Nov 29, 2023

@elmattic Could you add a changelog entry for this?

@elmattic elmattic added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 41b8f01 Nov 30, 2023
27 checks passed
@elmattic elmattic deleted the elmattic/compute-state-duration branch November 30, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants