Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump tipset lookup cache #3751

Merged
merged 3 commits into from
Nov 27, 2023
Merged

fix: bump tipset lookup cache #3751

merged 3 commits into from
Nov 27, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Nov 27, 2023

Summary of changes

Changes introduced in this pull request:

  • Tipset lookup must be fast. Looking up tipsets in O(n) time breaks Forest.
  • This PR is a work-around until we can implement a better lookup function.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review November 27, 2023 14:47
@lemmih lemmih requested a review from a team as a code owner November 27, 2023 14:47
@lemmih lemmih requested review from ruseinov and elmattic and removed request for a team November 27, 2023 14:47
@lemmih lemmih added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit 15ce1a9 Nov 27, 2023
27 checks passed
@lemmih lemmih deleted the lemmih/bump-tipset-lookup-cache branch November 27, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants