Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] MinerGetBaseInfo Lotus-compatible RPC. #3786

Merged
merged 8 commits into from
Dec 8, 2023
Merged

[Feature] MinerGetBaseInfo Lotus-compatible RPC. #3786

merged 8 commits into from
Dec 8, 2023

Conversation

ruseinov
Copy link
Contributor

@ruseinov ruseinov commented Dec 4, 2023 •
edited

Summary of changes

Changes introduced in this pull request:

  • MinerGetBaseInfo Lotus-compatible RPC

Reference issue to close (if applicable)

work on #3639

Other information and links

Tested with: forest-tool api compare --filter MinerGetBaseInfo --lotus /dns/127.0.0.1/tcp/1234/http snapshot-latest

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@ruseinov ruseinov marked this pull request as ready for review December 4, 2023 11:00
@ruseinov ruseinov requested a review from a team as a code owner December 4, 2023 11:00
@ruseinov ruseinov requested review from hanabi1224 and sudo-shashank and removed request for a team December 4, 2023 11:00
lemmih
lemmih reviewed Dec 4, 2023
View reviewed changes
src/rpc_api/data_types.rs Outdated Show resolved Hide resolved
lemmih
lemmih approved these changes Dec 4, 2023
View reviewed changes
src/state_manager/mod.rs Outdated Show resolved Hide resolved
src/state_manager/mod.rs Outdated Show resolved Hide resolved
ruseinov and others added 4 commits December 8, 2023 08:55
@ruseinov @lemmih
Update src/state_manager/mod.rs
3ef3c5a 
Co-authored-by: David Himmelstrup <david.himmelstrup@chainsafe.io>
@ruseinov @lemmih
Update src/state_manager/mod.rs
b0f0b9c 
Co-authored-by: David Himmelstrup <david.himmelstrup@chainsafe.io>
@ruseinov @lemmih
Update src/rpc_api/data_types.rs
6d95618 
Co-authored-by: David Himmelstrup <david.himmelstrup@chainsafe.io>
@ruseinov
Merge branch 'main' into ru/feature/miner-get-base-info
5f7f2b6
@ruseinov ruseinov added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit 91d2524 Dec 8, 2023
26 checks passed
@ruseinov ruseinov deleted the ru/feature/miner-get-base-info branch December 8, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ruseinov @lemmih @hanabi1224