Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement StateSearchMsg and StateSearchMsgLimited RPC APIs #3801

Merged
merged 24 commits into from
Jan 4, 2024

Conversation

hanabi1224
Copy link
Contributor

Summary of changes

As part of #3639

Note: This PR is based on #3783
Note: The return_dec field in the response is ignored for now, related tracking issues: #3784 and #3769

Changes introduced in this pull request:

  • implement StateSearchMsg and StateSearchMsgLimited RPC APIs
     Running `target/debug/forest-tool api compare /home/me/fr/snapshots/calibnet/forest_snapshot_calibnet_2023-12-06_height_1150811.forest.car.zst --filter StateSearch -n 200`
| RPC Method                           | Forest | Lotus |
|--------------------------------------|--------|-------|
| Filecoin.StateSearchMsg (753)        | Valid  | Valid |
| Filecoin.StateSearchMsgLimited (753) | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih
Copy link
Contributor

lemmih commented Dec 8, 2023

Hmm, okay, dealing with all of the different return types is rough. Let's just set return_dec to {} for now.

@hanabi1224 hanabi1224 mentioned this pull request Dec 8, 2023
4 tasks
@hanabi1224 hanabi1224 marked this pull request as ready for review December 8, 2023 10:54
@hanabi1224 hanabi1224 requested a review from a team as a code owner December 8, 2023 10:54
@hanabi1224 hanabi1224 requested review from elmattic and sudo-shashank and removed request for a team December 8, 2023 10:54
Copy link
Contributor

@elmattic elmattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/rpc/state_api.rs Outdated Show resolved Hide resolved
src/rpc/state_api.rs Outdated Show resolved Hide resolved
@elmattic elmattic added this pull request to the merge queue Jan 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 4, 2024
@hanabi1224 hanabi1224 added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit ced0f75 Jan 4, 2024
27 checks passed
@hanabi1224 hanabi1224 deleted the hm/impl-state-search-msg-api branch January 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants