-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl EthGasPrice RPC API #3806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
requested review from
ruseinov and
sudo-shashank
and removed request for
a team
December 7, 2023 10:44
lemmih
reviewed
Dec 8, 2023
src/rpc_api/mod.rs
Outdated
#[derive(Debug, Deserialize, Serialize, Default)] | ||
pub struct GasPriceResult(#[serde(with = "stringify")] pub BigInt); | ||
|
||
pub mod stringify { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be hexify
? And it should probably live in lotus_json/mod.rs
. It'll definitely be used by other RPC methods as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
lemmih
approved these changes
Dec 8, 2023
elmattic
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As part of #3640
Changes introduced in this pull request:
Filecoin.EthGasPrice
RPC APIforest-tool api compare
Lotus code
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist