Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feta: add --run-ignored flag to forest-tool api compare #3807

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Dec 7, 2023

Summary of changes

Changes introduced in this pull request:

  • Add --run-ignored flag to forest-tool api compare.
  • Make the test for EthBlockNumber less strict with respect to which epoch is the most recent.

Flag help line:

      --run-ignored <RUN_IGNORED>  Behavior for tests marked as `ignored` [default: default] [possible values: default, ignored-only, all]

Everything is now valid by default:

RPC Method Forest Lotus
Filecoin.BeaconGetEntry Valid Valid
Filecoin.ChainGetBlock Valid Valid
Filecoin.ChainGetBlockMessages (65) Valid Valid
Filecoin.ChainGetGenesis Valid Valid
Filecoin.ChainGetMessage (4) Valid Valid
Filecoin.ChainGetMessagesInTipset (20) Valid Valid
Filecoin.ChainGetParentMessages (65) Valid Valid
Filecoin.ChainGetTipSet Valid Valid
Filecoin.ChainGetTipSetByHeight Valid Valid
Filecoin.ChainHasObj Valid Valid
Filecoin.ChainHead Valid Valid
Filecoin.ChainReadObj Valid Valid
Filecoin.EthAccounts Valid Valid
Filecoin.EthBlockNumber Valid Valid
Filecoin.EthChainId Valid Valid
Filecoin.MpoolPending Valid Valid
Filecoin.NetAddrsListen Valid Valid
Filecoin.NetPeers Valid Valid
Filecoin.Session Valid Valid
Filecoin.StartTime Valid Valid
Filecoin.StateAccountKey (8) Valid Valid
Filecoin.StateCall (7) Valid Valid
Filecoin.StateCirculatingSupply (20) Valid Valid
Filecoin.StateGetActor Valid Valid
Filecoin.StateGetRandomnessFromBeacon Valid Valid
Filecoin.StateGetRandomnessFromTickets Valid Valid
Filecoin.StateLookupID (6) Valid Valid
Filecoin.StateMinerActiveSectors (66) Valid Valid
Filecoin.StateMinerDeadlines (65) Valid Valid
Filecoin.StateMinerFaults (65) Valid Valid
Filecoin.StateMinerInfo (65) Valid Valid
Filecoin.StateMinerPower (65) Valid Valid
Filecoin.StateMinerProvingDeadline (65) Valid Valid
Filecoin.StateMinerRecoveries (65) Valid Valid
Filecoin.StateNetworkName Valid Valid
Filecoin.StateNetworkVersion Valid Valid
Filecoin.StateReadState (2) Valid Valid
Filecoin.StateSectorGetInfo Valid Valid
Filecoin.StateVMCirculatingSupplyInternal (20) Valid Valid
Filecoin.Version Valid Valid
Filecoin.WalletBalance Valid Valid
Filecoin.WalletVerify Valid Valid

The failing tests can be inspected with --run-ignored ignored-only:

RPC Method Forest Lotus
Filecoin.Discover MissingMethod Valid
Filecoin.NetInfo Valid MissingMethod
Filecoin.StateDecodeParams MissingMethod Valid
Filecoin.StateSearchMsg (4) MissingMethod InternalServerError
Filecoin.StateSearchMsgLimited (4) MissingMethod InternalServerError

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review December 7, 2023 13:51
@lemmih lemmih requested a review from a team as a code owner December 7, 2023 13:51
@lemmih lemmih requested review from ruseinov and elmattic and removed request for a team December 7, 2023 13:51
@lemmih lemmih added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit f583dbf Dec 7, 2023
26 checks passed
@lemmih lemmih deleted the lemmih/api-compare-ignore branch December 7, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants