BlockHeader Update #385
Merged
BlockHeader Update #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
ansermino,
austinabell and
dutterbutter
as code owners
|
Not entirely sure where to put PostProof, so its in header.rs for now |
austinabell
suggested changes
Apr 29, 2020
| pub struct BeaconEntry { | ||
| round: u64, | ||
| data: Vec<u8>, | ||
| prev_round: u64, |
There was a problem hiding this comment.
Why have this as a variable? Not needed when prev_round can just give you this?
There was a problem hiding this comment.
It will be used later in an upcoming PR.
There was a problem hiding this comment.
but can always just call the function for this instead of having it as a field?
dutterbutter
approved these changes
Apr 29, 2020
|
Just for reference: filecoin-project/specs#918 |
austinabell
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links