Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements verify consensus fault syscall and reorg vm crates #386

Merged
merged 10 commits into from
Apr 30, 2020
Merged

Implements verify consensus fault syscall and reorg vm crates #386

merged 10 commits into from
Apr 30, 2020

Conversation

dutterbutter
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • implements verify consensus fault syscall
  • moves default runtime into interpreter crate due to dependency issues involving statetree and actors

Reference issue to close (if applicable)

Closes #306

Other information and links

austinabell
austinabell suggested changes Apr 29, 2020
View reviewed changes
blockchain/state_manager/src/lib.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/power/mod.rs Outdated Show resolved Hide resolved
vm/interpreter/src/default_syscalls.rs Outdated Show resolved Hide resolved
vm/interpreter/src/default_syscalls.rs Outdated Show resolved Hide resolved
vm/interpreter/src/default_syscalls.rs Show resolved Hide resolved
vm/interpreter/src/gas_syscalls.rs Outdated Show resolved Hide resolved
vm/interpreter/src/default_syscalls.rs Outdated Show resolved Hide resolved
vm/interpreter/src/default_syscalls.rs Outdated Show resolved Hide resolved
vm/interpreter/src/default_syscalls.rs Outdated Show resolved Hide resolved
vm/interpreter/src/default_syscalls.rs Outdated Show resolved Hide resolved
austinabell
austinabell suggested changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the downcasting thing and should be good

vm/actor/src/builtin/paych/mod.rs Outdated Show resolved Hide resolved
vm/actor/src/builtin/power/mod.rs Show resolved Hide resolved
austinabell
austinabell suggested changes Apr 30, 2020
View reviewed changes
vm/actor/src/builtin/paych/mod.rs Outdated Show resolved Hide resolved
ec2
ec2 approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@ec2 ec2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that question i have

ec2
ec2 requested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@ec2 ec2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upon further investigation, looks like you need to implement step 3

@dutterbutter
Copy link
Contributor Author

upon further investigation, looks like you need to implement step 3

Yeah, will make changes

@dutterbutter dutterbutter requested a review from ec2 April 30, 2020 17:45
@dutterbutter dutterbutter merged commit 1aa2e64 into master Apr 30, 2020
@dutterbutter dutterbutter deleted the dustin/consensus-fault branch April 30, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@austinabell austinabell austinabell approved these changes

@ansermino ansermino Awaiting requested review from ansermino

Assignees
No one assigned
Labels
Status: Needs Review VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verify_consensus_fault syscall
3 participants
@dutterbutter @ec2 @austinabell