Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop updates and refactoring #388

Merged
merged 16 commits into from
May 1, 2020
Merged

Interop updates and refactoring #388

merged 16 commits into from
May 1, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Interop updates and refactoring chain store logic to be more consistent
  • Updated hello protocol handling to route requests through ChainSyncer
    • This isn't ideal in our current setup, because that thread could be busy syncing, but is fine for now
    • Could potentially access the heaviest tipset with some Arc shared memory between the libp2p thread and chainsyncer, which could be a better solution, but I won't make any big changes yet because we may want those messages being passed through the chainsyncer for metrics on the peers

Still a few things to be ironed out and debugged, but gives a much cleaner setup to work off of and split up remaining tasks.

#384 (Will try to detail issues to do now before closing that issue though)

Reference issue to close (if applicable)

Closes
Other information and links

README.md Outdated
### Testing
### Config

To run the node with custom config and bootnodes, the `--config` or `-c` flag can be used to specify a toml file with the options. The main configurations options include but are not limited to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To run the node with custom config and bootnodes, the `--config` or `-c` flag can be used to specify a toml file with the options. The main configurations options include but are not limited to:
To run the node with custom config and bootnodes, the `--config` or `-c` flag can be used to specify a TOML file with the options. The main configurations options include but are not limited to:

Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just that one suggested change to the readme.

README.md Outdated
Comment on lines 42 to 55
### Config

To run the node with custom config and bootnodes, the `--config` or `-c` flag can be used to specify a TOML file with the options. The main configurations options include but are not limited to:

```toml
data_dir = "<directory for all chain and networking data>"
genesis_file = "<relative file path of genesis car file>"

[network]
listening_multiaddr = "<multiaddress>"
bootstrap_peers = ["<multiaddress>"]
```

Example of a [multiaddress](https://github.com/multiformats/multiaddr): `"/ip4/54.186.82.90/tcp/1347"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo the below is more clear. However, I will leave it to your judgment.

Configuration

Run the node with custom config and bootnodes

forest --config /path/to/your_config.toml

Example of config options available:

data_dir = "<directory for all chain and networking data>"
genesis_file = "<relative file path of genesis car file>"

[network]
listening_multiaddr = "<multiaddress>"
bootstrap_peers = ["<multiaddress>"]

Example of a multiaddress: "/ip4/54.186.82.90/tcp/1347"

@austinabell austinabell merged commit 0b589d7 into master May 1, 2020
@austinabell austinabell deleted the austin/interop branch May 1, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants