-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interop updates and refactoring #388
Conversation
e0cd2c0
to
b429d7b
Compare
README.md
Outdated
### Testing | ||
### Config | ||
|
||
To run the node with custom config and bootnodes, the `--config` or `-c` flag can be used to specify a toml file with the options. The main configurations options include but are not limited to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To run the node with custom config and bootnodes, the `--config` or `-c` flag can be used to specify a toml file with the options. The main configurations options include but are not limited to: | |
To run the node with custom config and bootnodes, the `--config` or `-c` flag can be used to specify a TOML file with the options. The main configurations options include but are not limited to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just that one suggested change to the readme.
README.md
Outdated
### Config | ||
|
||
To run the node with custom config and bootnodes, the `--config` or `-c` flag can be used to specify a TOML file with the options. The main configurations options include but are not limited to: | ||
|
||
```toml | ||
data_dir = "<directory for all chain and networking data>" | ||
genesis_file = "<relative file path of genesis car file>" | ||
|
||
[network] | ||
listening_multiaddr = "<multiaddress>" | ||
bootstrap_peers = ["<multiaddress>"] | ||
``` | ||
|
||
Example of a [multiaddress](https://github.com/multiformats/multiaddr): `"/ip4/54.186.82.90/tcp/1347"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo the below is more clear. However, I will leave it to your judgment.
Configuration
Run the node with custom config and bootnodes
forest --config /path/to/your_config.toml
Example of config options available:
data_dir = "<directory for all chain and networking data>"
genesis_file = "<relative file path of genesis car file>"
[network]
listening_multiaddr = "<multiaddress>"
bootstrap_peers = ["<multiaddress>"]
Example of a multiaddress: "/ip4/54.186.82.90/tcp/1347"
Summary of changes
Changes introduced in this pull request:
Still a few things to be ironed out and debugged, but gives a much cleaner setup to work off of and split up remaining tasks.
#384 (Will try to detail issues to do now before closing that issue though)
Reference issue to close (if applicable)
Closes
Other information and links