NV22 dragon state migration #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LesnyRumcajs
force-pushed
the
dragon-state-migration
branch
3 times, most recently
from
2afd31a
to
50102fb
Compare
LesnyRumcajs
force-pushed
the
dragon-state-migration
branch
from
fb5043a
to
515753f
Compare
LesnyRumcajs
force-pushed
the
dragon-state-migration
branch
3 times, most recently
from
f2cd2d1
to
71903f7
Compare
LesnyRumcajs
force-pushed
the
dragon-state-migration
branch
from
71903f7
to
0754f35
Compare
LesnyRumcajs
requested review from
hanabi1224 and
sudo-shashank
and removed request for
a team
ruseinov
approved these changes
Mar 7, 2024
ruseinov
reviewed
Mar 7, 2024
| @@ -78,18 +80,29 @@ impl<BS: Blockstore + Send + Sync> StateMigration<BS> { | |||
| } | |||
|
|
|||
| let cache = MigrationCache::new(NonZeroUsize::new(10_000).expect("infallible")); | |||
| let num_threads = std::env::var("FOREST_STATE_MIGRATION_THREADS") | |||
There was a problem hiding this comment.
nit: would validate that to avoid footgun.
There was a problem hiding this comment.
I forced it to at least 3.
ruseinov
reviewed
Mar 7, 2024
| .build()?; | ||
|
|
||
| let (state_tx, state_rx) = crossbeam_channel::bounded(1); | ||
| let (job_tx, job_rx) = crossbeam_channel::bounded(1); | ||
| let (state_tx, state_rx) = crossbeam_channel::bounded(30); |
There was a problem hiding this comment.
why crossbeam if we're using flume elsewhere?
There was a problem hiding this comment.
Outside of the scope of this PR. Maybe it could be replaced elsewhere.
ruseinov
reviewed
Mar 7, 2024
| let (state_tx, state_rx) = crossbeam_channel::bounded(1); | ||
| let (job_tx, job_rx) = crossbeam_channel::bounded(1); | ||
| let (state_tx, state_rx) = crossbeam_channel::bounded(30); | ||
| let (job_tx, job_rx) = crossbeam_channel::bounded(30); |
There was a problem hiding this comment.
nit: why are the channels bound specifically to 30?
There was a problem hiding this comment.
Magic number, same as cache set to 10k. Setting it to higher value, just like with cache sizes, may increase the memory footprint.
There was a problem hiding this comment.
as long as it works. I would probably make it a constant with a little comment instead, but not critical.
lemmih
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #3856
Other information and links
Change checklist