-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up tipsets #397
Clean up tipsets #397
Conversation
I had not noticed the casing issue... I'm surprised no ones OCD flared up haha. Good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
So I think the inconsistent casing was due to the spec using both casings interchangably and the go implementations using TipSet...
the inconsistency has bugged me and I prefer Tipset..
but I'll defer to other's opinions which is preferred for all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥🔥🔥
Summary of changes
Changes introduced in this pull request:
Tipset
types to all use a lowercases
Tipset::new
now doesn't clone block headers, and only clonesCid
s after the verification is doneTipset::is_empty
is removed because tipsets are guaranteed to never be emptyFullTipset::new
now asserts that the vector of blocks isn't empty which we were already assuming in some places