Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Dependencies #399

Merged
merged 4 commits into from
May 7, 2020
Merged

Bump Dependencies #399

merged 4 commits into from
May 7, 2020

Conversation

ec2
Copy link
Member

@ec2 ec2 commented May 7, 2020 •
edited

Summary of changes
Changes introduced in this pull request:

  • bump async-std from 1.4 to 1.5
  • bump base64 from 1.12.0 to 1.12.1
  • bump rocksdb from 1.13.0 to 1.14.0

Reference issue to close (if applicable)

Closes

Other information and links

@ec2 ec2 changed the title bump async-std version Bump async-std version from 1.4 to 1.5 May 7, 2020
austinabell
austinabell approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, async std is already being resolved to 1.5 before this change. Was there a specific reason this needed to be updated?

@ec2 ec2 changed the title Bump async-std version from 1.4 to 1.5 Bump Dependencies May 7, 2020
austinabell
austinabell approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new changes lgtm also

@ec2 ec2 merged commit 2052eb9 into master May 7, 2020
@ec2 ec2 deleted the ec2/asyncstd/1.5.0 branch May 7, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
Maintenance Status: Merge Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ec2 @austinabell