feat(daemon): add --p2p-listen-address arg to forest
#3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
requested review from
ruseinov and
LesnyRumcajs
and removed request for
a team
src/cli_shared/cli/mod.rs
Outdated
| @@ -57,6 +58,9 @@ pub struct CliOpts { | |||
| /// Address used for RPC. By defaults binds on localhost on port 2345. | |||
| #[arg(long)] | |||
| pub rpc_address: Option<SocketAddr>, | |||
| /// P2P addresses, e.g. `--p2p-address /ip4/0.0.0.0/tcp/12345 --p2p-address /ip4/0.0.0.0/tcp/12346` | |||
There was a problem hiding this comment.
Let's use the word listening somewhere. I tend to grep for such keywords, and it's ultimately what it does. Perhaps --p2p-listening-address? Otherwise, at first glance, I'd assume it's an address to which Forest should connect.
Co-authored-by: Hubert <hubert@chainsafe.io>
hanabi1224
changed the title
--p2p-adderss arg to forest--p2p-listening-address arg to forest
LesnyRumcajs
approved these changes
Feb 27, 2024
ruseinov
reviewed
Feb 28, 2024
| @@ -174,6 +178,10 @@ impl CliOpts { | |||
| } | |||
| } | |||
|
|
|||
| if let Some(addresses) = &self.p2p_listening_address { | |||
| cfg.network.listening_multiaddrs = addresses.clone(); | |||
There was a problem hiding this comment.
nit: not a fan of "listening". "listen" is better. And is actually the way it's put for in e.g. ssh configs. Otherwise good to go.
There was a problem hiding this comment.
@LesnyRumcajs How about using listen instead of listening?
There was a problem hiding this comment.
@ruseinov fixed.
hanabi1224
changed the title
--p2p-listening-address arg to forest--p2p-listen-address arg to forest
lemmih
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As part of #3990
This PR allows overriding p2p listening addresses via CLI options, which is easier than using a config file. The next step is updating
forest-iacto publicly expose the p2p addresses of forest nodes to allow accepting connections from new peers, to improve discoverability and connectivity.Changes introduced in this pull request:
--p2p-listen-addressCLI option toforestdaemon--p2p-listen-address A --p2p-listen-address B)Reference issue to close (if applicable)
Closes
Other information and links
Change checklist