Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor crypto and address to libraries #40

Merged
merged 12 commits into from
Nov 27, 2019
Merged

Refactor crypto and address to libraries #40

merged 12 commits into from
Nov 27, 2019

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Nov 26, 2019 •
edited

  • Refactors crypto operations and types to own library
  • Moves address to own library to avoid circular dependency
  • Implements verify SECP256k1 to be tested once the key type and signer implementation complete (no intermediate vectors to test with)

Needs to be tested with a standard data format in, whenever specced out or intermediate vectors given.

finishes #33

dutterbutter
dutterbutter approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@austinabell austinabell merged commit ff9b675 into master Nov 27, 2019
@austinabell austinabell deleted the austin/cryptorefactor branch November 27, 2019 12:43
@austinabell austinabell mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansermino ansermino ansermino approved these changes

@GregTheGreek GregTheGreek GregTheGreek approved these changes

@dutterbutter dutterbutter dutterbutter approved these changes

@ec2 ec2 Awaiting requested review from ec2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@austinabell @ansermino @GregTheGreek @dutterbutter