-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rupan/reward actor tests #403
Conversation
Not sure why test is failing because cargo test passes on my laptop |
Yeah don't worry that's not anything to do with this PR, @ec2 had that on his branch. Just the linker is not working consistently on the CI rn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on it since it's outside of changes, but can you add #[allow(dead_code)]
on the get_state()
function in the mock rt? This new test does not use it and it adds a warning to the test execution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, I see now how weird their test setup is, would be nice to be able to share that expect fail logic across tests but we can do that later/ doesn't really matter
ticket_count: 0, | ||
}; | ||
|
||
//Expect call to fail because actor doesnt have enough tokens to reward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//Expect call to fail because actor doesnt have enough tokens to reward | |
// Expect call to fail because actor doesnt have enough tokens to reward |
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #315
Other information and links
Didn't get to do this but we should probably create a func as a wrapper around call to revert state if call is being used instead of manually fixing state every time.