Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: head changes should always be sent as an array #4068

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Mar 15, 2024

Summary of changes

Changes introduced in this pull request:

  • Send head changes as an array.

Unfortunately, we don't have a way of testing the chain_notify channel yet. That will be part of a later PR.

Reference issue to close (if applicable)

Closes #4069

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review March 15, 2024 16:51
@lemmih lemmih requested a review from a team as a code owner March 15, 2024 16:51
@lemmih lemmih requested review from hanabi1224 and aatifsyed and removed request for a team March 15, 2024 16:51
@LesnyRumcajs
Copy link
Member

Is this covered by tests to ensure eternal compatibility?

@lemmih
Copy link
Contributor Author

lemmih commented Mar 18, 2024

Is this covered by tests to ensure eternal compatibility?

Not yet. We don't have the infrastructure to test channel responses. :(

@lemmih
Copy link
Contributor Author

lemmih commented Mar 18, 2024

Right now, we can only test request/response pairs. Channels and subscriptions require re-working our testing harness.

@lemmih lemmih added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit cb1ac58 Mar 18, 2024
32 checks passed
@lemmih lemmih deleted the lemmih/chain-notify-array branch March 18, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChainNotify should return an array of head changes
4 participants