Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Block verification in ChainSync #409

Merged
merged 5 commits into from
May 12, 2020
Merged

Async Block verification in ChainSync #409

merged 5 commits into from
May 12, 2020

Conversation

ec2
Copy link
Member

@ec2 ec2 commented May 12, 2020

Summary of changes
Changes introduced in this pull request:

  • Very small PR. Makes the Block validation in the syncer asynchronous. This is going to be used in Drand when verifying the Beacon Entries.
  • Although this is primarily for Drand, this is a step towards asynchronously verifying different parts of a block (eg. signature, timestamp, vrf, etc... )

Reference issue to close (if applicable)

Closes

Other information and links

@ec2 ec2 self-assigned this May 12, 2020
@ec2 ec2 changed the title Async Block verification is ChainSync Async Block verification in ChainSync May 12, 2020
@ec2 ec2 merged commit ef7aafd into master May 12, 2020
@ec2 ec2 deleted the ec2/async-block-verify branch May 12, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvermeulen timvermeulen timvermeulen approved these changes

@austinabell austinabell austinabell approved these changes

@StaticallyTypedAnxiety StaticallyTypedAnxiety StaticallyTypedAnxiety approved these changes

@ansermino ansermino Awaiting requested review from ansermino

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

@flodesi flodesi Awaiting requested review from flodesi

@RajarupanSampanthan RajarupanSampanthan Awaiting requested review from RajarupanSampanthan

Assignees

@ec2 ec2

Labels
Blockchain Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ec2 @timvermeulen @austinabell @StaticallyTypedAnxiety