-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore old height infos #4091
Restore old height infos #4091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about Butterflynet and Devnet? These (and Liftoff) should be marked as mandatory, preferably via static checks or tests, so that HEIGHT_INFOS
is invalid without them.
@LesnyRumcajs, do you have any idea why Devnet checks failed? |
Yes. I'll send a PR your way soon. |
Thanks! @LesnyRumcajs |
Summary of changes
This PR is a follow-up of #4080, which was restoring the
Liftoff
height entry.Changes introduced in this pull request:
Breeze
,Smoke
, andIgnition
entries for CalibnetBreeze
,Smoke
,Ignition
,ActorsV2
,Liftoff
, andCalico
entries for Devnet and ButterflynetThose heights are used at different places in the protocol and can have a significant impact, too.
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist