Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old height infos #4091

Merged
merged 11 commits into from
Mar 22, 2024
Merged

Restore old height infos #4091

merged 11 commits into from
Mar 22, 2024

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Mar 21, 2024

Summary of changes

This PR is a follow-up of #4080, which was restoring the Liftoff height entry.

Changes introduced in this pull request:

  • Restore Breeze, Smoke, and Ignition entries for Calibnet
  • Restore Breeze, Smoke, Ignition, ActorsV2, Liftoff, and Calico entries for Devnet and Butterflynet
  • Add unit tests

Those heights are used at different places in the protocol and can have a significant impact, too.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review March 21, 2024 09:28
@elmattic elmattic requested a review from a team as a code owner March 21, 2024 09:28
@elmattic elmattic requested review from hanabi1224 and sudo-shashank and removed request for a team March 21, 2024 09:28
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Butterflynet and Devnet? These (and Liftoff) should be marked as mandatory, preferably via static checks or tests, so that HEIGHT_INFOS is invalid without them.

@elmattic
Copy link
Contributor Author

@LesnyRumcajs, do you have any idea why Devnet checks failed?

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs, do you have any idea why Devnet checks failed?

Yes. I'll send a PR your way soon.

@LesnyRumcajs
Copy link
Member

@elmattic #4097 Please take a look to see if the change makes sense. If so, feel free to merge it with your branch.

@elmattic
Copy link
Contributor Author

Thanks! @LesnyRumcajs

@elmattic elmattic added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit 33ca381 Mar 22, 2024
28 checks passed
@elmattic elmattic deleted the elmattic/restore-calibnet-heights branch March 22, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants