Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Filecoin.StateAccountKey #4093

Merged
merged 7 commits into from
Mar 22, 2024
Merged

Fix Filecoin.StateAccountKey #4093

merged 7 commits into from
Mar 22, 2024

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Mar 21, 2024

Summary of changes

Changes introduced in this pull request:

  • Fix parsing issue
$ ./target/debug/forest-tool api compare --lotus /ip4/127.0.0.1/tcp/1234/http --forest /ip4/127.0.0.1/tcp/2345/http forest_snapshot_calibnet_2024-03-18_height_1448006.forest.car.zst --filter StateAccountKey
| RPC Method                     | Forest | Lotus |
|--------------------------------|--------|-------|
| Filecoin.StateAccountKey (120) | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review March 21, 2024 13:39
@elmattic elmattic requested a review from a team as a code owner March 21, 2024 13:39
@elmattic elmattic requested review from hanabi1224 and LesnyRumcajs and removed request for a team March 21, 2024 13:39
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it from the blacklist?

@elmattic elmattic added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit 4244cb6 Mar 22, 2024
27 of 28 checks passed
@elmattic elmattic deleted the elmattic/fix-state-account-key branch March 22, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants